Change in vdsm[master]: vdsm-tool: simplify getting modules by names.

ybronhei at redhat.com ybronhei at redhat.com
Sun Aug 17 23:41:09 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: simplify getting modules by names.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/31464/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 50:     configurer_to_trigger = []
Line 51: 
Line 52:     sys.stdout.write("\nChecking configuration status...\n\n")
Line 53:     for c in args.modules:
Line 54:         isconfigured = c.isconfigured()
> I remember it was made to be similar with the code 
we use it few times later on. i don't want to call to the isconfigured() function each time
Line 55:         override = args.force and isconfigured != CONFIGURED
Line 56:         if not override and not c.validate():
Line 57:             raise InvalidConfig(
Line 58:                 "Configuration of %s is invalid" % c.getName()


-- 
To view, visit http://gerrit.ovirt.org/31464
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb056e18573b1aadefe57a6eee4ec1396dad9775
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list