Change in vdsm[master]: Hack upgrading ovirt-3.2 vdsm to newer

Alon Bar-Lev alonbl at redhat.com
Sun Aug 17 18:44:45 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: Hack upgrading ovirt-3.2 vdsm to newer
......................................................................


Patch Set 1:

(2 comments)

I truly do  not understand the uninstall thing... why can't we properly detect this state within explicit asking for version.

http://gerrit.ovirt.org/#/c/31561/1/vdsm.spec.in
File vdsm.spec.in:

Line 725: if [ "$1" -ge 1 ]; then
Line 726:     fulloldpkg=`rpm -q vdsm`
Line 727:     oldver=${fulloldpkg##vdsm-}
Line 728:     oldver=${oldver%-*.*.*}
Line 729:     if [ "$(echo '%{oldver}' | sed 's/^4\.10\..*/OK/')" == "OK" ]; then
it cannot be %{} or you get the spec variable which is incorrect.

please do this entire statement using single sed....

 if [ "$(rpm -q vdsm 2> /dev/null | sed 's/^vdsm-4\.10\..*/OK/')" = "OK" ]; then
Line 730:         touch %{_localstatedir}/run/%{vdsm_name}/requires_configure
Line 731:     fi
Line 732: fi
Line 733: 


Line 726:     fulloldpkg=`rpm -q vdsm`
Line 727:     oldver=${fulloldpkg##vdsm-}
Line 728:     oldver=${oldver%-*.*.*}
Line 729:     if [ "$(echo '%{oldver}' | sed 's/^4\.10\..*/OK/')" == "OK" ]; then
Line 730:         touch %{_localstatedir}/run/%{vdsm_name}/requires_configure
quotes please

this won't survive boot
Line 731:     fi
Line 732: fi
Line 733: 
Line 734: # After vdsm install we should create the logs files.


-- 
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list