Change in vdsm[master]: Configure iSCSI iface.net_ifacename

danken at redhat.com danken at redhat.com
Fri Aug 15 19:55:04 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Configure iSCSI iface.net_ifacename
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 324:         self._conf = {}
Line 325:         self.name = name
Line 326: 
Line 327:         ni = netinfo.NetInfo()
Line 328:         network = tuple(ni.getBridgedNetworksAndVlansForIface(name))
> > This returns multiple of networks (and vlans) that use the "name" interfa
The corner case is a network setup with a bridgeless storage network on eth0, and a bridged network on eth0.100. Given eth0, you'd be using the bridge instead of eth0.100.
Line 329: 
Line 330:         if network:
Line 331:             self._conf['iface.net_ifacename'] = network[0][0]
Line 332:         else:


-- 
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list