Change in vdsm[ovirt-3.5]: virt: Change log level for disk stats collection failure

alitke at redhat.com alitke at redhat.com
Fri Aug 15 12:23:57 UTC 2014


Hello Nir Soffer, Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/31536

to review the following change.

Change subject: virt: Change log level for disk stats collection failure
......................................................................

virt: Change log level for disk stats collection failure

When hotplugging a new disk, samples for the newly added device will not
be immediately available which results in a KeyError Traceback in
vdsm.log.  Since this condition is expected, downgrade the logging level
from exception to warning.  In the case of a hot plugged disk, the
failure resolves once enough samples have been collected.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1112998

Change-Id: If04623778b590f1f76eedbdcb2eda433d0a24514
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/29677
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/31536/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4309c8e..1847680 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -588,7 +588,7 @@
                 try:
                     dLatency = _avgLatencyCalc(sInfo[dName], eInfo[dName])
                 except (KeyError, TypeError):
-                    self._log.exception("Disk %s latency not available", dName)
+                    self._log.warning("Disk %s latency not available", dName)
 
             stats[dName].update(dLatency)
 


-- 
To view, visit http://gerrit.ovirt.org/31536
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If04623778b590f1f76eedbdcb2eda433d0a24514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list