Change in vdsm[master]: vdsm-tool: suppoort dependencies between ModuleConfigure

Alon Bar-Lev alonbl at redhat.com
Thu Aug 14 16:36:34 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

thanks, that's simple enough.

http://gerrit.ovirt.org/#/c/31423/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 186:         sys.stdout.write(
Line 187:             "error: argument --module: "
Line 188:             "invalid choice: %s (choose from %s)" % (modulesNames, next_)
Line 189:         )
Line 190:         sys.exit(2)
why don't you raise an exception?
Line 191: 
Line 192:     return retNames
Line 193: 
Line 194: 


-- 
To view, visit http://gerrit.ovirt.org/31423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf63ce9aa3ca8edb82091d09b976e8e23896524e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list