Change in vdsm[master]: utils: Remove duplicate set non-blocking functions

danken at redhat.com danken at redhat.com
Thu Aug 14 14:39:32 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: utils: Remove duplicate set non-blocking functions
......................................................................


utils: Remove duplicate set non-blocking functions

Current code had 2 implementations of functions that turned on the
O_NONBLOCK flag on file descriptors, none of which were in lib, to avoid
creating yet another implementation for lib code to use, one of existing
implementations was moved to utils.

Change-Id: I1fd242e8b437e485e45127d083c35957ccecf577
Signed-off-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/29413
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M lib/vdsm/utils.py
M vdsm/protocoldetector.py
M vdsm/storage/misc.py
M vdsm/storage/remoteFileHandler.py
4 files changed, 10 insertions(+), 19 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Saggi Mizrahi: Looks good to me, approved
  Dima Kuznetsov: Verified



-- 
To view, visit http://gerrit.ovirt.org/29413
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1fd242e8b437e485e45127d083c35957ccecf577
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list