Change in vdsm[master]: vdsm-tool: suppoort dependencies between ModuleConfigure
mtayer at redhat.com
mtayer at redhat.com
Thu Aug 14 13:04:30 UTC 2014
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31423/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 251: args.modules = _getConfigurers().keys()
Line 252: else:
Line 253: _validateModulesNames(args.modules, parser.format_usage())
Line 254:
Line 255: args.modules = _sort_modules(_add_dependencies(args.modules))
> usually this duplicates the logic, but maybe I am wrong.
I tried, I have to say I don't like it that way.
It's part of arg parsing logic and not _add_dependencies...
Also I need to pass usage to _add_dependencies which seems unrelated.
if not args.modules:
args.modules = _getConfigurers().keys()
args.modules = _sort_modules(_add_dependencies(args.modules, parser.format_usage()))
...
def _add_dependencies(modulesNames, usage):
try:
...
except KeyError:
_printChoiceError(modulesNames, name_, usage)
sys.exit(2)
def _printChoiceError(modules, choice, usage):
# imitate argparse's 'choices'
# we cannot when mocking 'choices' since it is evaluated before mocking.
sys.stdout.write(usage)
sys.stdout.write(
"error: argument --module: "
"invalid choice: %s (choose from %s)" %
(
modules,
choice
)
)
Line 256:
Line 257: args.modules = [_getConfigurers()[cName] for cName in args.modules]
Line 258:
--
To view, visit http://gerrit.ovirt.org/31423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf63ce9aa3ca8edb82091d09b976e8e23896524e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list