Change in vdsm[master]: vdsClient: alternative ways to provide password

danken at redhat.com danken at redhat.com
Thu Aug 14 07:26:05 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsClient: alternative ways to provide password
......................................................................


vdsClient: alternative ways to provide password

Current method to provide password for vdsClient commands is typing it
in the command line. The BZ1032525 requests to provide safer way.

The patch implements new alternatives to provide command's password
value instead of a plain text.

This change introduces an new field, 'auth=', usage:
 * auth=[alt:value] with following posibilities:
 ** auth=file:path - read password from the first line of the file
                     pointed by path
 ** auth=env:name - read password from the environment variable 'name'
 ** auth=pass:password - use plaintext password, provided in case would
                         want to depricate the old format altogether.

This change affects the following commands:
Group 1:
 * connectStorageServer
 * disconnectStorageServer
 * validateStorageServerConnection
 Commands in this group pass password as part of conList format, such as
 id=...,user=...,password=...
 These commands can drop password= altogether, and use only auth=, if
 both are provided, auth= takes precedence.

Group 2:
 * desktopLogin
 * discoverST
 Commands in this group receive password as a mandatory  argument, at
 a known index, for example: [address] [user] [pass], to avoid breaking
 compatibility, password argument has to be specified, even when using
 auth=, where auth= can come anywhere after all the mandatory arguments.
 For example: vdsClient someCommand 127.0.0.1 user - auth=method:...
 (note the '-')

Group 3:
 * setVmTicket
 auth=... can be passed only after '--' parameter, to avoid collision
 with the fifth optional parameter
 For example:
 vdsClient setVmTicket 127.0.0.1 user - disconnect -- auth=method:...

Bug-Url: https://bugzilla.redhat.com/1032525
Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
Signed-off-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24733
Reviewed-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M client/vdsClient.py
M tests/vdsClientTests.py
2 files changed, 492 insertions(+), 38 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Saggi Mizrahi: Looks good to me, approved
  Dima Kuznetsov: Verified



-- 
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list