Change in vdsm[master]: vdsm-tool: changing root checking in configurator.
ybronhei at redhat.com
ybronhei at redhat.com
Thu Aug 14 07:10:21 UTC 2014
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: changing root checking in configurator.
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/31293/4/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 672: )
Line 673:
Line 674:
Line 675: @expose("configure")
Line 676: @requiresRoot
and what if someone imports configurator and run LibvirtModuleConfigure.configure directly ?
I prefer this decorator only above functions that we know that require root
Line 677: def configure(*args):
Line 678: """
Line 679: configure [-h|...]
Line 680: Configure external services for vdsm
--
To view, visit http://gerrit.ovirt.org/31293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list