Change in vdsm[master]: Veth devices are shown as NICs + test
danken at redhat.com
danken at redhat.com
Wed Aug 13 09:24:10 UTC 2014
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Veth devices are shown as NICs + test
......................................................................
Veth devices are shown as NICs + test
Veth LinkType was not listed in tuple, therefore veths were
evaluated as NICs.
New test adds dummies and veths with _fakeNics prefix and with
non _fakeNics prefix and then verify if fake nics are shown in
netinfo.nics() and the others are not.
Bug-Url: https://bugzilla.redhat.com/1125177
Change-Id: Ide618510b46eee28d939c32e8188bbd38349d660
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31166
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
M tests/netinfoTests.py
2 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31166
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide618510b46eee28d939c32e8188bbd38349d660
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list