Change in vdsm[master]: configfile: sort dict items inserted to config files for con...

nsoffer at redhat.com nsoffer at redhat.com
Wed Aug 13 08:03:44 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: configfile: sort dict items inserted to config files for consistency.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/31289/2/tests/toolTests.py
File tests/toolTests.py:

Line 236:                                        "# start conf-3.4.4\n"
Line 237:                                        "key1=val\n"
Line 238:                                        "key3=val\n"
Line 239:                                        "key4=val\n"
Line 240:                                        "# end conf-3.4.4\n")
This very nice test!

But testing that keys outside the # start and # end markers are not modified should be a different test. As it is now, breaking the code handling start and end markers will break this test which is about keeping vdsm-tool modified values sorted.

If this already tested separately, you can remove the key2 line in this test, and if it is not tested separately, I would add a separate test for this.
Line 241: 
Line 242:     def testPrefixAndPrepend(self):
Line 243:         self._writeConf("/var/log/libvirt/libvirtd.log {\n"
Line 244:                         "        weekly\n"


-- 
To view, visit http://gerrit.ovirt.org/31289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7705b046d993cc08eac6b09a6ebba34bd8986620
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list