Change in vdsm[master]: vdsm-tool: suppoort dependencies between ModuleConfigure
mtayer at redhat.com
mtayer at redhat.com
Wed Aug 13 06:01:41 UTC 2014
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/31423/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 177: with_dep = set(modules)
Line 178: for c in _configurers:
Line 179: if c.getName() in modules:
Line 180: with_dep.update(c.requires())
Line 181: return list(with_dep)
> shouldn't this be logically reversed?
Right.
will fix.
Line 182:
Line 183:
Line 184: def _sort_modules(modules):
Line 185: sortedModules = []
Line 185: sortedModules = []
Line 186: while modules:
Line 187: foundNext = False
Line 188:
Line 189: for c in _configurers:
> I do not understand the usage of _configurers, it is just the global list t
yes.
I will try to make it clearer with a prep patch.
Line 190: if c.getName() in modules:
Line 191: if not c.requires() or c.requires().issubset(sortedModules):
Line 192: foundNext = True
Line 193: modules.remove(c.getName())
--
To view, visit http://gerrit.ovirt.org/31423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf63ce9aa3ca8edb82091d09b976e8e23896524e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list