Change in vdsm[master]: vdsm-tool: use geteuid() instead of getuid() for root check.

nsoffer at redhat.com nsoffer at redhat.com
Tue Aug 12 18:21:09 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vdsm-tool: use geteuid() instead of getuid() for root check.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/31317/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-08-12 06:42:48 -0400
Line 6: 
Line 7: vdsm-tool: use geteuid() instead of getuid() for root check.
Line 8: 
Line 9: This is expected to have to consequence. checking for effective user id
to -> no ?
Line 10: is more accurate for permissions check.
Line 11: 
Line 12: Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9


-- 
To view, visit http://gerrit.ovirt.org/31317
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list