Change in vdsm[master]: vdsm-tool: changing root checking in configurator.

mtayer at redhat.com mtayer at redhat.com
Tue Aug 12 15:04:10 UTC 2014


mooli tayer has posted comments on this change.

Change subject: vdsm-tool: changing root checking in configurator.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/31293/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 678:     def wrapper(*args, **kwargs):
Line 679:         if os.getuid() != 0:
Line 680:             raise NotRootError()
Line 681:         func(*args, **kwargs)
Line 682:     return wrapper
> I think a decorator as Mooli propose is the right way to handle this, and i
Let me understand.
do you propose to put this at utils?
Line 683: 
Line 684: 
Line 685: @expose("configure")
Line 686: @requiresRoot


-- 
To view, visit http://gerrit.ovirt.org/31293
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list