Change in vdsm[master]: Live Merge: Resolve unknown merge status in vdsm after host ...

alitke at redhat.com alitke at redhat.com
Tue Aug 12 14:27:37 UTC 2014


Adam Litke has posted comments on this change.

Change subject: Live Merge: Resolve unknown merge status in vdsm after host crash
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/31267/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1834:             subChainTailVol = sdDom.produceVolume(imgUUID, subChain[-1])
Line 1835:             children = subChainTailVol.getChildren()
Line 1836:             for childID in children:
Line 1837:                 sdDom.produceVolume(imgUUID, childID).setParentMeta(dstParent)
Line 1838:             if len(children) == 0:
> if not children:
I'll have another round with these so I can fix this while I am at it.
Line 1839:                 self.log.debug("Leaf volume is being removed from the chain. "
Line 1840:                                "Marking it ILLEGAL to prevent data corruption")
Line 1841:                 subChainTailVol.setLegality(volume.ILLEGAL_VOL)
Line 1842: 


-- 
To view, visit http://gerrit.ovirt.org/31267
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5e4ad67216d30c3149a53c2ea65cc97601bfc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list