Change in vdsm[master]: Live Merge: Return more info from _driveGetActualVolumeChain

alitke at redhat.com alitke at redhat.com
Tue Aug 12 13:44:47 UTC 2014


Adam Litke has posted comments on this change.

Change subject: Live Merge: Return more info from _driveGetActualVolumeChain
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/31364/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5473:             if not sourceXML:
Line 5474:                 break
Line 5475:             sourceAttr = ('file', 'dev')[drive.blockDev]
Line 5476:             path = sourceXML.getAttribute(sourceAttr)
Line 5477:             info = {'id': pathToVolID(drive, path)}
> probably unneeded temporary
info is going to be conditionally updated by a future patch so it should probably remain.  We will add the 'allocation' value if and only if the drive is a block device.
Line 5478:             volChain.insert(0, info)
Line 5479:             bsXML = findElement(diskXML, 'backingStore')
Line 5480:             if not bsXML:
Line 5481:                 break


Line 5499:             self.log.debug("Unable to determine volume chain. Skipping volume "
Line 5500:                            "chain synchronization for drive %s", drive.name)
Line 5501:             return
Line 5502: 
Line 5503:         volumes = [v['id'] for v in ret]
> I see this twice, this is my threshold to think about factor out this code 
ok.
Line 5504:         self.log.debug("vdsm chain: %s, libvirt chain: %s", curVols, volumes)
Line 5505: 
Line 5506:         # Ask the storage to sync metadata according to the new chain
Line 5507:         self.cif.irs.imageSyncVolumeChain(drive.domainID, drive.imageID,


-- 
To view, visit http://gerrit.ovirt.org/31364
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01d142a68903048accc95eb04d9930c326965db0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list