Change in vdsm[master]: vdsm-tool: reorgenize module configurers.
Alon Bar-Lev
alonbl at redhat.com
Tue Aug 12 13:22:19 UTC 2014
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: reorgenize module configurers.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 32:
Line 33:
Line 34: __configurers = (
Line 35: libvirt.Libvirt(),
Line 36: sanlock.Sanlock(),
can we dynamic scan the module for all classes that inherit from x?
Line 37: )
Line 38:
Line 39:
Line 40: @expose("configure")
http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm/tool/configurators/__init__.py:
Line 41: #
Line 42: CONFIGURED, NOT_CONFIGURED, NOT_SURE = range(3)
Line 43:
Line 44:
Line 45: class ModuleConfigure(object):
unless this is vdsm project convention... I think this belongs to be within the parent module.
within this directory we should only have the actual implementations.
Line 46:
Line 47: def __init__(self):
Line 48: pass
Line 49:
Line 45: class ModuleConfigure(object):
Line 46:
Line 47: def __init__(self):
Line 48: pass
Line 49:
add sort hint property?
Line 50: def getName(self):
Line 51: return None
Line 52:
Line 53: def getServices(self):
--
To view, visit http://gerrit.ovirt.org/31400
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic79d400760e425f6f4863b6a33c69aa14fb0c623
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list