Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

ybronhei at redhat.com ybronhei at redhat.com
Tue Aug 12 10:40:06 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................


Patch Set 5: -Code-Review

(1 comment)

so still need to improve the comments. not only me complaining

http://gerrit.ovirt.org/#/c/30909/5/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 760: 
Line 761:         rc = service.service_reload("multipathd")
Line 762:         if rc != 0:
Line 763:             status = service.service_status("multipathd", False)
Line 764:             if status == 0:
> If the service is not running, this will raise ServiceOperationError, not r
nice catch ..
Line 765:                 raise RuntimeError("Failed to reload Multipath.")
Line 766: 
Line 767:     def isconfigured(self, *args):
Line 768:         """


-- 
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list