Change in vdsm[master]: tc: add hfsc class parsing support

danken at redhat.com danken at redhat.com
Mon Aug 11 16:42:20 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tc: add hfsc class parsing support
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/30132/8/vdsm/network/tc/cls.py
File vdsm/network/tc/cls.py:

Line 71:         (_parser.parse_str(tokens),  # Get and consume 'd'
Line 72:          _parser.parse_time(tokens)),
Line 73:         (_parser.parse_str(tokens),  # Get and consume 'm2'
Line 74:          _parser.parse_rate(tokens)),
Line 75:         ))
why not make pep8 happy by unindenting this a bit?
Line 76: 
Line 77: 
Line 78: _spec = {
Line 79:     'hfsc': {


-- 
To view, visit http://gerrit.ovirt.org/30132
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10373eafbc9316f13994a5b5fe3f4ccda0554b8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list