Change in vdsm[master]: vdsm-tool: changing root checking in configurator.

mtayer at redhat.com mtayer at redhat.com
Mon Aug 11 13:31:14 UTC 2014


mooli tayer has posted comments on this change.

Change subject: vdsm-tool: changing root checking in configurator.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/31293/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 672:     SanlockModuleConfigure(),
Line 673: )
Line 674: 
Line 675: 
Line 676: def requiresRoot(func):
> Isn't this more generic utility that can be used in lot of other places in 
I think we need to move it there (__init__.py) only if other modules will need it.
Line 677:     @functools.wraps(func)
Line 678:     def wrapper(*args, **kwargs):
Line 679:         if os.getuid() != 0:
Line 680:             raise NotRootError()


-- 
To view, visit http://gerrit.ovirt.org/31293
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list