Change in vdsm[master]: configfile: sort dict items inserted to config files for con...

nsoffer at redhat.com nsoffer at redhat.com
Sun Aug 10 12:22:17 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: configfile: sort dict items inserted to config files for consistency.
......................................................................


Patch Set 1:

I think a tests are missing - will help to understand the results when writing new section and when editing existing section.

You probably have some tests that ignored keys order, you can now simplify the test to check keys order.

-- 
To view, visit http://gerrit.ovirt.org/31289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7705b046d993cc08eac6b09a6ebba34bd8986620
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list