Change in vdsm[ovirt-3.5]: Revert "jsonrpc: Accept all stomp commands"

ybronhei at redhat.com ybronhei at redhat.com
Fri Aug 8 17:24:32 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Revert "jsonrpc: Accept all stomp commands"
......................................................................


Revert "jsonrpc: Accept all stomp commands"

There is no verification whether incoming stomp messages are correct for
correct runtime context. This work is planned for next release. We can
use protocol detection as sanity check so we will recieve only messages
which we know are correct.

This reverts commit 6c2892a2a0bc337dcd4a40da54d08d3d63f95028.

Change-Id: I3aef9781e09cb582e9a5422638b82327974f1213
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: http://gerrit.ovirt.org/30033
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompReactor.py
2 files changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved

Objections:
  Nir Soffer: I would prefer that you didn't submit this



-- 
To view, visit http://gerrit.ovirt.org/30033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3aef9781e09cb582e9a5422638b82327974f1213
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list