Change in vdsm[master]: vm: more generic recovery check

danken at redhat.com danken at redhat.com
Fri Aug 8 11:48:27 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: more generic recovery check
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/31241/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2694:                                       _VMCHANNEL_DEVICE_NAME)
Line 2695:         else:
Line 2696:             self.log.warning('detected disabled vmchannel.'
Line 2697:                              ' This should be done ONLY for debug purposes'
Line 2698:                              ' and never in production environments')
> 'vmchannel' (and 'qgaEnable') isn't documented anywhere, not in the schema 
ack.
Line 2699:         if utils.tobool(self.conf.get('qgaEnable', 'true')):
Line 2700:             domxml._appendAgentDevice(
Line 2701:                 self._qemuguestSocketFile.decode('utf-8'),
Line 2702:                 _QEMU_GA_DEVICE_NAME)


-- 
To view, visit http://gerrit.ovirt.org/31241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0cc57129e9c8e6545f9a947329adf1f9e82648f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list