Change in vdsm[ovirt-3.5]: Live Merge: Ignore libvirt block job events

ybronhei at redhat.com ybronhei at redhat.com
Fri Aug 8 08:31:32 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Live Merge: Ignore libvirt block job events
......................................................................


Live Merge: Ignore libvirt block job events

Since VDSM needs to handle missed block job completion events that may
have been emitted while the daemon was stopped, it is best to not rely
on the events at all and initiate all cleanup operations from the
existing polling function.  Since a volume chain sync can be a
relatively expensive operation involving HSM calls, run it in a separate
thread.  Depending on the current state of the storage, the sync may
need to be retried.

Change-Id: Ibbcdca4c0c0e45e9323ecfef9ce2fce10d8451a5
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/30046
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124970
Reviewed-on: http://gerrit.ovirt.org/31049
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/clientIF.py
M vdsm/virt/vm.py
2 files changed, 125 insertions(+), 77 deletions(-)

Approvals:
  Adam Litke: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Federico Simoncelli: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/31049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbcdca4c0c0e45e9323ecfef9ce2fce10d8451a5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list