Change in vdsm[master]: utils: Move functionality from storage.misc

nsoffer at redhat.com nsoffer at redhat.com
Thu Aug 7 16:33:25 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: utils: Move functionality from storage.misc
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/30850/3/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 172:         rc = misc.execCmd(cmd, sudo=True)[0]
Line 173:         if rc != 0:
Line 174:             raise se.MultipathSetupError()
Line 175:     if utils.isOvirtNode():
Line 176:         NodeCfg().persist(self._MPATH_CONF)
First, this is not related to moving code from misc to utils - move to another patch about supporting ovirt-node.

Second, it does not make sense to check everywhere if we are running on ovirt-node - instead we should call utils.preristFile, which will do the right thing (nothing in not running on ovirt-node).
Line 177: 
Line 178:     # Flush all unused multipath device maps
Line 179:     misc.execCmd([constants.EXT_MULTIPATH, "-F"], sudo=True)
Line 180: 


-- 
To view, visit http://gerrit.ovirt.org/30850
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091083caa868931fb3a0bcf3bc2df98091daee45
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list