Change in vdsm[master]: Explicit casting of port to string in cannonizeHostPort func...
alukiano at redhat.com
alukiano at redhat.com
Thu Aug 7 16:02:55 UTC 2014
Artyom Lukianov has posted comments on this change.
Change subject: Explicit casting of port to string in cannonizeHostPort function
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31209/1/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 28:
Line 29:
Line 30: d_useSSL = False
Line 31: d_tsPath = '/etc/pki/vdsm'
Line 32: d_addr = '0'
> 'port' is a string all over this module. We'd better make it be a complete
I can to change in virt/migration.py lines:
hostPort = vdscli.cannonizeHostPort(
self._dst,
config.getint('addresses', 'management_port'))
to
hostPort = vdscli.cannonizeHostPort(
self._dst,
config.get('addresses', 'management_port'))
is it ok for you?
Line 33: d_port = '54321'
Line 34:
Line 35:
Line 36: def wrap_transport(transport):
--
To view, visit http://gerrit.ovirt.org/31209
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3082abee5f27f84a7731d783027a30fa02d846
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list