Change in vdsm[master]: fencing: Skip fencing if host is maintaining its lease

oourfali at redhat.com oourfali at redhat.com
Thu Aug 7 13:08:39 UTC 2014


Oved Ourfali has posted comments on this change.

Change subject: fencing: Skip fencing if host is maintaining its lease
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/30762/8/vdsm/API.py
File vdsm/API.py:

Line 1198: 
Line 1199:         if action not in ('status', 'on', 'off', 'reboot'):
Line 1200:             raise ValueError('illegal action ' + action)
Line 1201: 
Line 1202:         if action != 'status' and not should_fence(policy):
> >When you return {"operationStatus": "skipped"}, does engine abort the fenc
I think both of you guys have a point here.
Currently, I don't see the harm going that way or another.
Given the fact that the patch was verified I suggest to proceed with it as is, unless there are any additional objections.
Line 1203:             self.log.debug("Skipping execution of action '%s'", action)
Line 1204:             return {'status': doneCode, 'operationStatus': 'skipped'}
Line 1205: 
Line 1206:         script = constants.EXT_FENCE_PREFIX + agent


-- 
To view, visit http://gerrit.ovirt.org/30762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list