Change in vdsm[master]: tc_tests: break down _ICMP into more understandable bits

danken at redhat.com danken at redhat.com
Thu Aug 7 08:10:55 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tc_tests: break down _ICMP into more understandable bits
......................................................................


tc_tests: break down _ICMP into more understandable bits

_ICMP used to be defined as just a long hex string and it was
difficult to remember what each byte stood for. With this change,
I made a breakdown with scapy, pasted it and broke down the hex
string into smaller significant pieces.

Change-Id: Ic6c5684ca8833807cf1dc05e9ccc4d97391c6168
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31171
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/tcTests.py
1 file changed, 28 insertions(+), 5 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31171
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6c5684ca8833807cf1dc05e9ccc4d97391c6168
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list