Change in vdsm[master]: blockSD: raise an exception if missing physical volume

nsoffer at redhat.com nsoffer at redhat.com
Wed Aug 6 18:03:39 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: blockSD: raise an exception if missing physical volume
......................................................................


Patch Set 7: -Code-Review

(1 comment)

http://gerrit.ovirt.org/#/c/27442/7/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 824: def getPV(pv):
Line 825:     pv = _lvminfo.getPv(_fqpvname(pv))
Line 826:     if not pv:
Line 827:         raise se.InaccessiblePhysDev(pv)
Line 828:     return pv
> In hsm.py we have:
Looks like Xavi forgot to include that file in the patch, because he describes this change in the commit message.
Line 829: 
Line 830: 
Line 831: def getAllPVs():
Line 832:     return _lvminfo.getAllPvs()


-- 
To view, visit http://gerrit.ovirt.org/27442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9932b044c8b439dc8b1f09191a5d89f4bc44c38a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list