Change in vdsm[ovirt-3.4]: net: Mark removed interfaces with NM_CONTROLLED=no

danken at redhat.com danken at redhat.com
Wed Aug 6 14:43:51 UTC 2014


Hello Yaniv Bronhaim, Antoni Segura Puimedon,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/31151

to review the following change.

Change subject: net: Mark removed interfaces with NM_CONTROLLED=no
......................................................................

net: Mark removed interfaces with NM_CONTROLLED=no

Change-Id: Iba3c6818ee8f2e843b019cd8ba25d7da3afe2f29
Related-To: https://bugzilla.redhat.com/1001186
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/30848
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/30887
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/netconf/ifcfg.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/31151/1

diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py
index 753668e..d60ef86 100644
--- a/vdsm/netconf/ifcfg.py
+++ b/vdsm/netconf/ifcfg.py
@@ -686,6 +686,7 @@
             hwlines = [line for line in nicFile if line.startswith('HWADDR=')]
         l = [self.CONFFILE_HEADER + '\n', 'DEVICE=%s\n' % nic, 'ONBOOT=yes\n',
              'MTU=%s\n' % netinfo.DEFAULT_MTU] + hwlines
+        l += 'NM_CONTROLLED=no\n'
         with open(cf, 'w') as nicFile:
             nicFile.writelines(l)
 


-- 
To view, visit http://gerrit.ovirt.org/31151
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba3c6818ee8f2e843b019cd8ba25d7da3afe2f29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list