Change in vdsm[master]: fencing: Skip fencing if host is maintaining its lease

nsoffer at redhat.com nsoffer at redhat.com
Wed Aug 6 13:51:23 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: fencing: Skip fencing if host is maintaining its lease
......................................................................


Patch Set 5: -Code-Review

(1 comment)

http://gerrit.ovirt.org/#/c/30762/5/vdsm/API.py
File vdsm/API.py:

Line 1198: 
Line 1199:         if action not in ('status', 'on', 'off', 'reboot'):
Line 1200:             raise ValueError('illegal action ' + action)
Line 1201: 
Line 1202:         if action != 'status' and not should_fence(policy):
> I think that an explicit 'on' should taken place regardless of should_fence
+1
Line 1203:             self.log.debug("Skipping execution of action '%s'", action)
Line 1204:             return {'status': doneCode, 'operationStatus': 'skipped'}
Line 1205: 
Line 1206:         script = constants.EXT_FENCE_PREFIX + agent


-- 
To view, visit http://gerrit.ovirt.org/30762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list