Change in vdsm[master]: sp: improve variables in _linkStorageDomain

danken at redhat.com danken at redhat.com
Wed Aug 6 08:54:36 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sp: improve variables in _linkStorageDomain
......................................................................


Patch Set 1: Code-Review+2

I hate the discrepancy between ln(1) and os.symplink. The former's "target" is the latter's "src".

I don't mind you siding with ln(1) if you prefer.

-- 
To view, visit http://gerrit.ovirt.org/31090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I696529865d270318662233f5c719f30d5b85d112
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list