Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

ybronhei at redhat.com ybronhei at redhat.com
Tue Aug 5 15:02:02 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.ovirt.org/#/c/30909/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 668: 
Line 669: class MultipathModuleConfigure(_ModuleConfigure):
Line 670: 
Line 671:     _MPATH_CONF = "/etc/multipath.conf"
Line 672: 
add a comment - start with 2 empty lines between the tags and the contents of the file
Line 673:     _STRG_MPATH_CONF = (
Line 674:         "\n\n"
Line 675:         "defaults {\n"
Line 676:         "    polling_interval        5\n"


Line 704:     _OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3",
Line 705:                  "# RHEV REVISION 0.4", "# RHEV REVISION 0.5",
Line 706:                  "# RHEV REVISION 0.6", "# RHEV REVISION 0.7",
Line 707:                  "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"]
Line 708: 
where is my explanation :( 

just copy it from isconfigured() doc to here
Line 709:     _MPATH_CONF_TAG = "# RHEV REVISION 1.0"
Line 710:     # Do not override conf file when private tag added by admin
Line 711:     _MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE"
Line 712: 


Line 706:                  "# RHEV REVISION 0.6", "# RHEV REVISION 0.7",
Line 707:                  "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"]
Line 708: 
Line 709:     _MPATH_CONF_TAG = "# RHEV REVISION 1.0"
Line 710:     # Do not override conf file when private tag added by admin
this tag\having "# RHEV PRIVATE" means that the configure won't override ....
Line 711:     _MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE"
Line 712: 
Line 713:     _MPATH_CONF_TEMPLATE = _MPATH_CONF_TAG + _STRG_MPATH_CONF
Line 714: 


-- 
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list