Change in vdsm[master]: sp: fix storage domain link detection

Federico Simoncelli fsimonce at redhat.com
Tue Aug 5 14:15:55 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: sp: fix storage domain link detection
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/30245/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 1118:     @unsecured
Line 1119:     def _linkStorageDomain(self, src, linkName):
Line 1120:         self.log.info("Linking %s to %s", src, linkName)
Line 1121:         try:
Line 1122:             current = os.readlink(linkName)
> I am worried that linkSrc can be confused with what "src" is. What about:
Since there are several renames I'll address them in another patch.
Line 1123:         except OSError as e:
Line 1124:             if e.errno != errno.ENOENT:
Line 1125:                 self.log.error("Can't link SD %s to %s", src, linkName,
Line 1126:                                exc_info=True)


-- 
To view, visit http://gerrit.ovirt.org/30245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37b44ac15f24be1271334e15ef47fc8316f259eb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list