Change in vdsm[master]: refine calculation of cpu topology

ybronhei at redhat.com ybronhei at redhat.com
Tue Aug 5 11:27:08 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: refine calculation of cpu topology
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/30896/12/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3407: # @numaTune:              #optional Indicates the numatune configuration.
Line 3408: #
Line 3409: # @guestNumaNodes:        #optional Indicates the guest numa topology.
Line 3410: #
Line 3411: # Since: 4.16.2
> The stucture is old. Only the new element is new.
my bad.. so you should add (as in bootMenuEnable param) - new in version xxx

and keep the Since as was
Line 3412: ##
Line 3413: {'type': 'VmParameters',
Line 3414:  'data': {'acpiEnable': 'bool', '*bootMenuEnable': 'bool',
Line 3415:           '*cpuShares': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'],


-- 
To view, visit http://gerrit.ovirt.org/30896
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list