Change in vdsm[master]: refine calculation of cpu topology

rgolan at redhat.com rgolan at redhat.com
Mon Aug 4 07:11:06 UTC 2014


Roy Golan has posted comments on this change.

Change subject: refine calculation of cpu topology
......................................................................


Patch Set 8:

(1 comment)

a

http://gerrit.ovirt.org/#/c/30896/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 422:     def toxml(self):
Line 423:         return self.doc.toprettyxml(encoding='utf-8')
Line 424: 
Line 425:     def _getSmp(self):
Line 426:         return self.conf.get('smp', '1')
> since you're introducing _topology, I'd say please move smp there and add m
I'll add smp. maxNumberOfSockets is equivilent to sockets
Line 427: 
Line 428:     def _calcTopology(self):
Line 429:         cores = int(self.conf.get('smpCoresPerSocket', '1'))
Line 430:         threads = int(self.conf.get('smpThreadsPerCore', '1'))


-- 
To view, visit http://gerrit.ovirt.org/30896
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list