Change in vdsm[master]: packaging: Changes for official builds

Alon Bar-Lev alonbl at redhat.com
Sun Aug 3 07:21:17 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Changes for official builds
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/30747/5/configure.ac
File configure.ac:

Line 191: AC_ARG_WITH(
Line 192:     [register-uri],
Line 193:     [AS_HELP_STRING([--with-register-uri=URI],
Line 194:                     [registration URI on engine side
Line 195:                      @<:@default=/OvirtEngineWeb/register@:>@])],
> It seems fine:
usually, I think the proper way to do this is [xxx] [yyyy] and not inline inside []
Line 196:     [VDSM_REG_URI="${withval}"],
Line 197:     [VDSM_REG_URI="/OvirtEngineWeb/register"])
Line 198: AC_SUBST([VDSM_REG_URI])
Line 199: 


-- 
To view, visit http://gerrit.ovirt.org/30747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae2854badc6b33073aa1d30e014172a3788057b5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list