Change in vdsm[master]: jsonrpc: logging requests and responses
danken at redhat.com
danken at redhat.com
Fri Aug 1 23:15:01 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: logging requests and responses
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/30923/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 457: self._workQueue.put_nowait(req)
Line 458:
Line 459: def _serveRequest(self, ctx, req):
Line 460: mangledMethod = req.method.replace(".", "_")
Line 461: self.log.debug("Calling '%s' in bridge with %s",
Since getVdsStats() and list() are so frequest, in binding_xmlrpc, we decided not to log them in DEBUG level.
How about doing the same here?
Line 462: req.method, req.params)
Line 463: try:
Line 464: method = getattr(self._bridge, mangledMethod)
Line 465: except AttributeError:
--
To view, visit http://gerrit.ovirt.org/30923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1785d466725310c711aef9ef1dadc60364a21bce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list