Change in vdsm[master]: fencing: Skip fencing if host is connected to storage

nsoffer at redhat.com nsoffer at redhat.com
Fri Aug 1 21:55:36 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: fencing: Skip fencing if host is connected to storage
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/30762/2/vdsm/API.py
File vdsm/API.py:

Line 1184:                             "Error during getHostLeaseStatus: '%s'",
Line 1185:                             result
Line 1186:                         )
Line 1187: 
Line 1188:             return execute
> This is example how to make the code more complicated to understand or main
Note that LIVE means that in host was maintaining its lease less then 80 seconds ago. It is possible that the host does not have access to the storage for 79 seconds when you check this. See the comments in clusterlock.py for more info.

This check should be performed at least 80 seconds after the host became non-responsive. Maybe we need to change the minimal timeout in the engine to ensure this?

This should documented in the code where you check for LIVE status.
Line 1189: 
Line 1190:         self.log.debug('fenceNode(addr=%s,port=%s,agent=%s,user=%s,passwd=%s,'
Line 1191:                        'action=%s,secure=%s,options=%s,fencingPolicy=%s)',
Line 1192:                        addr, port, agent, username, 'XXXX', action, secure,


-- 
To view, visit http://gerrit.ovirt.org/30762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list