Change in vdsm[master]: net_configurators: Fix optional configurator importing

Federico Simoncelli fsimonce at redhat.com
Fri Aug 1 16:11:29 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: net_configurators: Fix optional configurator importing
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/30924/2/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 46: from ..sourceroute import StaticSourceRoute, DynamicSourceRoute
Line 47: import dsaversion  # TODO: Make parent package import when vdsm is a package
Line 48: 
Line 49: 
Line 50: def is_valid():
maybe I finally found a better name: is_available?
Line 51:     return True
Line 52: 
Line 53: 
Line 54: def _hwaddr_required():


-- 
To view, visit http://gerrit.ovirt.org/30924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff38f5e334167e34ba379be164e690f2888f5fea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list