Change in vdsm[master]: domainMonitor: Extract domain monitoring methods

danken at redhat.com danken at redhat.com
Fri Aug 1 14:35:41 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: domainMonitor: Extract domain monitoring methods
......................................................................


domainMonitor: Extract domain monitoring methods

The _domainMonitor method was extremely long and was doing too much.
This patch breaks it to multiple small methods to make it easier to
understand and modify.

One of the planned changes is to allow _domainMonitor to abort in the
middle if a monitor is stopped. Implementing this in the original method
would only make it worse. To make it easy, operation that may take lot
of time were extracted into separate methods.

This patch does not change the behavior of the monitor, only move code
around.

Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27714
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/domainMonitor.py
1 file changed, 110 insertions(+), 67 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27714
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list