Change in vdsm[master]: New before_device_create/before_nic_hotplug hook: privatevlan

danken at redhat.com danken at redhat.com
Wed Apr 30 00:04:56 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: New before_device_create/before_nic_hotplug hook: privatevlan
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

Please do not give up on gerrit. What has been broken exactly?

And certainly please do not give up on this hook. I would only wish to better understand the issue of CTRL_IP_LEARNING=dhcp. If it's broken, there's either a bug in libvirt code or in its documentation. Please open it in bugzilla (or discuss it in libvir-list) so it can be addressed.

http://gerrit.ovirt.org/#/c/24195/7/vdsm_hooks/privatevlan/README
File vdsm_hooks/privatevlan/README:

Line 27: 
Line 28: privatevlan_guest_learn=none
Line 29:   This is an optional parameter.  It is recommended that you set this
Line 30:   to none, or leave unset.  DHCP snooping functionality is claimed to
Line 31:   be available ("dhcp"), but seems broken with qemu guests.  The
Please open a libvirt bug about this, and state its number here. If it's like that due to a missing qemu feature, let libvirt should mention this in its documentation http://libvirt.org/formatnwfilter.html#nwfelemsRulesAdvIPAddrDetection
Line 32:   default setting is "any", which means that if the guest IP isn't
Line 33:   provided, the filter is not applied until an outbound IP packet is
Line 34:   sent, then the IP is locked in until shutdown or migrate.
Line 35: 


-- 
To view, visit http://gerrit.ovirt.org/24195
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idda6f193c0095241bc1540a0241d49426c000fb3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Samuel <mik at miknet.net>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Michael Samuel <mik at miknet.net>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list