Change in vdsm[master]: hooks: Add hook for fake VM stats

dkuznets at redhat.com dkuznets at redhat.com
Tue Apr 29 13:57:16 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: hooks: Add hook for fake VM stats
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.ovirt.org/#/c/25927/13/vdsm/API.py
File vdsm/API.py:

Line 1198:     def getAllVmStats(self):
Line 1199:         """
Line 1200:         Get statistics of all running VMs.
Line 1201:         """
Line 1202:         hooks.before_get_all_vm_stats()
> I understand the performance issue, but please add the possibility to drop 
Done
Line 1203:         vms = self.getVMList()
Line 1204:         statsList = []
Line 1205:         for s in vms['vmList']:
Line 1206:             response = VM(s['vmId']).getStats()


http://gerrit.ovirt.org/#/c/25927/13/vdsm/vdsmd.8.in
File vdsm/vdsmd.8.in:

Line 76: The uuid of the virtual machine may be deduced from that xml, but it is also
Line 77: available as the environment variable
Line 78: .B vmId.
Line 79: 
Line 80: The before_network_setup and after_network_setup hooks do also include an
> please document the json argument of before_get_all_vm_stats, too.
Done
Line 81: extra environment variable
Line 82: .B _hook_json
Line 83: which holds a pointer to a file with the network parameters that vdsm is
Line 84: setting up (


-- 
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list