Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

amuller at redhat.com amuller at redhat.com
Tue Apr 29 13:09:54 UTC 2014


Assaf Muller has posted comments on this change.

Change subject: vdsm-tool: Change upgrade mechanism
......................................................................


Patch Set 1:

If you git blame and look at the patches that introduced the upgrade mechanism you'd see that Saggi NACK'd inheritance, on the basis that inheritance should never be used in Python (This is an oversimplification but was the basis for his argument). I disagreed with him but implemented it without inheritance as he asked. Let's see if you can convince him now :)

-- 
To view, visit http://gerrit.ovirt.org/27193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list