Change in vdsm[ovirt-3.4]: vm: Fix guest channel symlink creation handling

ybronhei at redhat.com ybronhei at redhat.com
Tue Apr 29 12:40:33 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vm: Fix guest channel symlink creation handling
......................................................................


vm: Fix guest channel symlink creation handling

In case of a restart of VDSM the symlinks and sockets won't get cleaned up.
Commit 4a7af02 partially fixed the issue, however it did not consider the
case of a crashing VDSM. In case of a crashing or unclean stop (kill)
of VDSM the symlinks are left behind and the recovery would fail.

This patch handles these cases and adds a bit more of documentation to the
code to improve the clarity of the cases it handles.

Change-Id: I24e5d8e7b7e338c683d4064585539444044bb77a
Bug-Url: https://bugzilla.redhat.com/1082986
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/26882
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27183
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/vm.py
1 file changed, 18 insertions(+), 5 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Vinzenz Feenstra: Verified



-- 
To view, visit http://gerrit.ovirt.org/27183
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24e5d8e7b7e338c683d4064585539444044bb77a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list