Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

laravot at redhat.com laravot at redhat.com
Tue Apr 29 09:49:14 UTC 2014


Liron Ar has posted comments on this change.

Change subject: core: fixing attribute error on fenceSpmStorage
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26358/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3528:         vars.task.setDefaultException(
Line 3529:             se.SpmFenceError("spUUID=%s, lastOwner=%s, lastLver=%s" %
Line 3530:                              (spUUID, lastOwner, lastLver)))
Line 3531:         pool = self.getPool(spUUID)
Line 3532:         if isinstance(pool.getBackend(), StoragePoolDiskBackend):
> Dan, in that scenario there's nothing to do - you can't "explode" because w
what i meant was is that the engine shouldn't be aware of what's being done here, the fact that nothing will be done currently for the other backend is an implementation detail, IMO it makes sense to keep it as is.
Line 3533:             pool.getBackend().invalidateMetadata()
Line 3534:             vars.task.getExclusiveLock(STORAGE, spUUID)
Line 3535:             pool.getBackend().forceFreeSpm()
Line 3536:         return dict(spm_st=self._getSpmStatusInfo(pool))


-- 
To view, visit http://gerrit.ovirt.org/26358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list