Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

danken at redhat.com danken at redhat.com
Tue Apr 29 09:22:39 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: core: fixing attribute error on fenceSpmStorage
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26358/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3528:         vars.task.setDefaultException(
Line 3529:             se.SpmFenceError("spUUID=%s, lastOwner=%s, lastLver=%s" %
Line 3530:                              (spUUID, lastOwner, lastLver)))
Line 3531:         pool = self.getPool(spUUID)
Line 3532:         if isinstance(pool.getBackend(), StoragePoolDiskBackend):
wouldn't it be much safer to explode if Engine asks for fenceSpmStorage() while our backend does not support it? Why would we want to silenetly ignore such a request?
Line 3533:             pool.getBackend().invalidateMetadata()
Line 3534:             vars.task.getExclusiveLock(STORAGE, spUUID)
Line 3535:             pool.getBackend().forceFreeSpm()
Line 3536:         return dict(spm_st=self._getSpmStatusInfo(pool))


-- 
To view, visit http://gerrit.ovirt.org/26358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list