Change in vdsm[master]: vm: simplify the releaseVm flow

fromani at redhat.com fromani at redhat.com
Tue Apr 29 07:51:52 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: simplify the releaseVm flow
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27175/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4285:         - sends SIGTERM (clean shutdown)
Line 4286:         - waits for 10s (hardcoded)
Line 4287:         - if !GRACEFUL:
Line 4288:           - sends SIGKILL (forced shutdown)
Line 4289:           - waits for 5s more (hardcoded)
If we want to change those values, I'm afraid we have no choice than propose a libvirt patch.
Line 4290:         so we actually do two clean shutdown requests and
Line 4291:         if the second fails, we resort to forced shutdown.
Line 4292:         """
Line 4293:         try:


-- 
To view, visit http://gerrit.ovirt.org/27175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list