Change in vdsm[master]: sp: fix spm start when failing to produce domain

nsoffer at redhat.com nsoffer at redhat.com
Mon Apr 28 19:18:27 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/25424/3/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 206:                 if domain.getDomainRole() == sd.REGULAR_DOMAIN:
Line 207:                     continue
Line 208: 
Line 209:                 self._backend.setDomainRegularRole(domain)
Line 210:             except se.StorageDomainDoesNotExist:
> iirc, this error can be raised only from within sdc.produce(). So either th
We need to catch exception raised in getDomainRole and in setDomainRole.
Line 211:                 self.log.error("Error when trying to find domain %s, ignoring",
Line 212:                                sdUUID, exc_info=True)
Line 213: 
Line 214:     @unsecured


-- 
To view, visit http://gerrit.ovirt.org/25424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list