Change in vdsm[master]: ifcfg: fix stp processing

asegurap at redhat.com asegurap at redhat.com
Mon Apr 28 15:40:46 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: ifcfg: fix stp processing
......................................................................


Patch Set 6: Verified+1

Changed the booleanize version so that it has proper error reporting and it is less forgiving.

Verified in the cmdline:

    toniel602 ~ # vdsClient -s 0 addNetwork bridge=err nics= stp=fail
    "fail" is not a valid bridge STP value.
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=err nics= stp=on  
    Done
    toniel602 ~ # vdsClient -s 0 delNetwork bridge=err nics=       
    Done
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=err nics= stp=False                               
    Done
    toniel602 ~ # cat /sys/class/net/err/bridge/stp_state             
    0
    toniel602 ~ # vdsClient -s 0 delNetwork bridge=err nics=
    Done
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=err nics= stp=on   
    Done
    toniel602 ~ # cat /sys/class/net/err/bridge/stp_state          
    1
    toniel602 ~ # vdsClient -s 0 delNetwork bridge=err nics=
    Done
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=err nics= stp=True 
    Done
    toniel602 ~ # cat /sys/class/net/err/bridge/stp_state            
    1

-- 
To view, visit http://gerrit.ovirt.org/27023
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a1a37485ae40b8c9f2037c671daa3e4c6ac3f90
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list